Repenting from making bracelets that have signs of shirk

Q: I made thread bracelets for a school project and my family. Since we’re from the subcontinent, amulets are common.

Some of my cousins asked for bracelets and I made them for their children to wear. I made for others but some of those people have moved out of the country and I am no longer in contact with them.

Also I had wandered into astrology and zodiac signs and stuff, discussing it with those around me including my classmates of which some are kaafirs and some Muslims. I did not know these were acts of shirk and most lasted from before to mid puberty. I don't know what to do so I can give charity on their behalf even if they are kaafirs since I'm not in touch with them.

Before I rarely prayed and fasted but now I know alhamdulillah I’m more practicing and have realized that the shirk I have spread. Is there a way to resolve the issue? I have no idea of their intentions and some are requesting bracelets but what should I say. 

Taking rent from a property that one had gifted to his children

Q: Please can you clarify the issue of gifts in the format of property.

A man in my city has divided 3 flats in the name of 6 children in his lifetime but the flats are in the name of 2 children۔ In addition, he still extracts rent from each flat. These 'gifts' are meant to be taken upon his death until which he continues to take until his demise. (ie avoiding laws of inheritance completely). 

He has 4 daughters and 2 sons. Is this jaiz? He is a nice man, but unfortunately this decision is more like a contractual gift, which may make him questionable on Judgement Day.

Kindly advise what is the truth. This conditional mentality regarding wealth pervades in certain communities here.